lkml.org 
[lkml]   [2016]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net v2] tipc: check minimum bearer MTU
From
Date
On Thu, 2016-12-01 at 12:02 +0100, Michal Kubecek wrote:
[...] 
> +/* check if device MTU is sufficient for tipc headers */
> +static inline bool tipc_check_mtu(struct net_device *dev, unsigned int reserve)
> +{
> + if (dev->mtu >= TIPC_MIN_BEARER_MTU + reserve)
> + return false;
> + netdev_warn(dev, "MTU too low for tipc bearer\n");
> + return true;
> +}
[...]

The comment says "check if ... sufficient" but the return value
indicates the opposite. Could you make these consistent?

Other than that, this looks OK to me. I haven't tested any version as
I don't know how to use TIPC.

Ben.

--
Ben Hutchings
A free society is one where it is safe to be unpopular. - Adlai
Stevenson

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-12-01 17:12    [W:0.048 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site