Messages in this thread | | | Subject | Re: [PATCH net v2] tipc: check minimum bearer MTU | From | Ben Hutchings <> | Date | Thu, 01 Dec 2016 16:11:18 +0000 |
| |
On Thu, 2016-12-01 at 12:02 +0100, Michal Kubecek wrote: [...] > +/* check if device MTU is sufficient for tipc headers */ > +static inline bool tipc_check_mtu(struct net_device *dev, unsigned int reserve) > +{ > + if (dev->mtu >= TIPC_MIN_BEARER_MTU + reserve) > + return false; > + netdev_warn(dev, "MTU too low for tipc bearer\n"); > + return true; > +} [...]
The comment says "check if ... sufficient" but the return value indicates the opposite. Could you make these consistent?
Other than that, this looks OK to me. I haven't tested any version as I don't know how to use TIPC.
Ben.
-- Ben Hutchings A free society is one where it is safe to be unpopular. - Adlai Stevenson
[unhandled content-type:application/pgp-signature] | |