Messages in this thread | | | Date | Wed, 9 Nov 2016 10:58:25 +0100 | From | Johan Hovold <> | Subject | Re: [PATCH net v2 2/4] net: ethernet: ti: cpsw: fix device and of_node leaks |
| |
On Tue, Nov 08, 2016 at 05:19:29PM -0600, Grygorii Strashko wrote: > > > On 11/03/2016 12:40 PM, Johan Hovold wrote: > > Make sure to drop the references taken by of_get_child_by_name() and > > bus_find_device() before returning from cpsw_phy_sel(). > > > > Note that holding a reference to the cpsw-phy-sel device does not > > prevent the devres-managed private data from going away. > > > > Fixes: 5892cd135e16 ("drivers: net: cpsw-phy-sel: Add new driver...") > > Cc: Mugunthan V N <mugunthanvnm@ti.com> > > Cc: Grygorii Strashko <grygorii.strashko@ti.com> > > Cc: linux-omap@vger.kernel.org > > Signed-off-by: Johan Hovold <johan@kernel.org> > > --- > > Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Thanks for the review. Note that David has already applied these, though.
Johan
| |