Messages in this thread | | | Date | Wed, 09 Nov 2016 18:56:43 -0500 (EST) | Subject | Re: [PATCH net-next v2 4/5] net: l2tp: cleanup: remove redundant condition | From | David Miller <> |
| |
From: Asbjoern Sloth Toennesen <asbjorn@asbjorn.st> Date: Mon, 7 Nov 2016 20:39:27 +0000
> These assignments follow this pattern: > > unsigned int foo:1; > struct nlattr *nla = info->attrs[bar]; > > if (nla) > foo = nla_get_flag(nla); /* expands to: foo = !!nla */ > > This could be simplified to: if (nla) foo = 1; > but lets just remove the condition and use the macro, > > foo = nla_get_flag(nla); > > Signed-off-by: Asbjoern Sloth Toennesen <asbjorn@asbjorn.st>
Applied.
| |