Messages in this thread | | | Date | Wed, 9 Nov 2016 13:38:00 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH] leds: Add mutex protection in brightness_show() |
| |
Hi!
> Initially the claim about no need for lock in brightness_show() > was valid as the function was just returning unchanged > LED brightness. After the addition of led_update_brightness() this
The claim was probably wrong from the day one, unless brightness is of type "atomic_t".
/* Ensures consistent access to the LED Flash Class device */ struct mutex led_access; };
This should really list fields that are protected by led_access.
Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |