lkml.org 
[lkml]   [2016]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 01/69] i2c: xgene: Avoid dma_buffer overrun
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Hoan Tran <hotran@apm.com>

    commit 603616017c35f4d0fbdbcace72adf9bf949c4a65 upstream.

    SMBus block command uses the first byte of buffer for the data length.
    The dma_buffer should be increased by 1 to avoid the overrun issue.

    Reported-by: Phil Endecott <phil_gjouf_endecott@chezphil.org>
    Signed-off-by: Hoan Tran <hotran@apm.com>
    Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/i2c/busses/i2c-xgene-slimpro.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/i2c/busses/i2c-xgene-slimpro.c
    +++ b/drivers/i2c/busses/i2c-xgene-slimpro.c
    @@ -105,7 +105,7 @@ struct slimpro_i2c_dev {
    struct mbox_chan *mbox_chan;
    struct mbox_client mbox_client;
    struct completion rd_complete;
    - u8 dma_buffer[I2C_SMBUS_BLOCK_MAX];
    + u8 dma_buffer[I2C_SMBUS_BLOCK_MAX + 1]; /* dma_buffer[0] is used for length */
    u32 *resp_msg;
    };


    \
     
     \ /
      Last update: 2016-11-09 11:51    [W:3.137 / U:0.508 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site