lkml.org 
[lkml]   [2016]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 29/69] hv: do not lose pending heartbeat vmbus packets
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Long Li <longli@microsoft.com>

    commit 407a3aee6ee2d2cb46d9ba3fc380bc29f35d020c upstream.

    The host keeps sending heartbeat packets independent of the
    guest responding to them. Even though we respond to the heartbeat messages at
    interrupt level, we can have situations where there maybe multiple heartbeat
    messages pending that have not been responded to. For instance this occurs when the
    VM is paused and the host continues to send the heartbeat messages.
    Address this issue by draining and responding to all
    the heartbeat messages that maybe pending.

    Signed-off-by: Long Li <longli@microsoft.com>
    Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/hv/hv_util.c | 10 +++++++---
    1 file changed, 7 insertions(+), 3 deletions(-)

    --- a/drivers/hv/hv_util.c
    +++ b/drivers/hv/hv_util.c
    @@ -283,10 +283,14 @@ static void heartbeat_onchannelcallback(
    u8 *hbeat_txf_buf = util_heartbeat.recv_buffer;
    struct icmsg_negotiate *negop = NULL;

    - vmbus_recvpacket(channel, hbeat_txf_buf,
    - PAGE_SIZE, &recvlen, &requestid);
    + while (1) {
    +
    + vmbus_recvpacket(channel, hbeat_txf_buf,
    + PAGE_SIZE, &recvlen, &requestid);
    +
    + if (!recvlen)
    + break;

    - if (recvlen > 0) {
    icmsghdrp = (struct icmsg_hdr *)&hbeat_txf_buf[
    sizeof(struct vmbuspipe_hdr)];


    \
     
     \ /
      Last update: 2016-11-09 11:48    [W:4.180 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site