lkml.org 
[lkml]   [2016]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2] xen/manage: correct return value check on xenbus_scanf()
    From
    Date
    On 08/11/16 08:44, Jan Beulich wrote:
    > A negative return value indicates an error; in fact the function at
    > present won't ever return zero.
    >
    > Signed-off-by: Jan Beulich <jbeulich@suse.com>

    Reviewed-by: Juergen Gross <jgross@suse.com>

    > ---
    > v2: For consistency with other code don't consider zero an error
    > (utilizing that xenbus_scanf() at present won't return zero).
    > Adjust commit message accordingly.
    > ---
    > drivers/xen/manage.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > --- 4.9-rc4/drivers/xen/manage.c
    > +++ 4.9-rc4-xen-manage-xenbus_scanf/drivers/xen/manage.c
    > @@ -277,7 +277,7 @@ static void sysrq_handler(struct xenbus_
    > err = xenbus_transaction_start(&xbt);
    > if (err)
    > return;
    > - if (!xenbus_scanf(xbt, "control", "sysrq", "%c", &sysrq_key)) {
    > + if (xenbus_scanf(xbt, "control", "sysrq", "%c", &sysrq_key) < 0) {
    > pr_err("Unable to read sysrq code in control/sysrq\n");
    > xenbus_transaction_end(xbt, 1);
    > return;
    >
    >

    \
     
     \ /
      Last update: 2016-11-08 08:52    [W:5.101 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site