lkml.org 
[lkml]   [2016]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] media: s5p-mfc include buffer size in error message
From
Date
On 11/04/2016 04:05 AM, Sylwester Nawrocki wrote:
> On 10/18/2016 02:43 AM, Shuah Khan wrote:
>> Include buffer size in s5p_mfc_alloc_priv_buf() the error message when it
>> fails to allocate the buffer. Remove the debug message that does the same.
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>> drivers/media/platform/s5p-mfc/s5p_mfc_opr.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr.c b/drivers/media/platform/s5p-mfc/s5p_mfc_opr.c
>> index 1e72502..eee16a1 100644
>> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr.c
>> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr.c
>> @@ -40,12 +40,11 @@ void s5p_mfc_init_regs(struct s5p_mfc_dev *dev)
>> int s5p_mfc_alloc_priv_buf(struct device *dev, dma_addr_t base,
>> struct s5p_mfc_priv_buf *b)
>> {
>> - mfc_debug(3, "Allocating priv: %zu\n", b->size);
>
> How about keeping this debug message, I think it would be useful
> to leave that information in the debug logs.

Sent v2 with just the error message change.

thanks,
-- Shuah

>
>> b->virt = dma_alloc_coherent(dev, b->size, &b->dma, GFP_KERNEL);
>>
>> if (!b->virt) {
>> - mfc_err("Allocating private buffer failed\n");
>> + mfc_err("Allocating private buffer of size %zu failed\n",
>> + b->size);
>> return -ENOMEM;
>> }
>
> --
> Thanks,
> Sylwester
>

\
 
 \ /
  Last update: 2016-11-08 00:41    [W:0.064 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site