lkml.org 
[lkml]   [2016]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ARC: [plat-eznps] remove IPI clear from SMP operations
From
Date
On 11/06/2016 11:34 PM, Noam Camus wrote:
> From: Noam Camus <noamca@mellanox.com>
>
> Generic IRQ mechanism is already acknowledge the IPI IRQ.
> Doing this once more time in IPI handler is not needed.

Changelog can be improved !
Generic IRQ mechanism can't ack the irq. The NPQ irqchip driver does this for all
irqs already - so no special handling is needed for IPI in NPS case.

-Vineet
>
> Signed-off-by: Noam Camus <noamca@mellanox.com>
> ---
> arch/arc/plat-eznps/smp.c | 6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arc/plat-eznps/smp.c b/arch/arc/plat-eznps/smp.c
> index 5e901f8..56a4c85 100644
> --- a/arch/arc/plat-eznps/smp.c
> +++ b/arch/arc/plat-eznps/smp.c
> @@ -140,16 +140,10 @@ static void eznps_init_per_cpu(int cpu)
> mtm_enable_core(cpu);
> }
>
> -static void eznps_ipi_clear(int irq)
> -{
> - write_aux_reg(CTOP_AUX_IACK, 1 << irq);
> -}
> -
> struct plat_smp_ops plat_smp_ops = {
> .info = smp_cpuinfo_buf,
> .init_early_smp = eznps_init_cpumasks,
> .cpu_kick = eznps_smp_wakeup_cpu,
> .ipi_send = eznps_ipi_send,
> .init_per_cpu = eznps_init_per_cpu,
> - .ipi_clear = eznps_ipi_clear,
> };

\
 
 \ /
  Last update: 2016-11-07 19:55    [W:0.052 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site