Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: Coding Style: Reverse XMAS tree declarations ? (was Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet) | Date | Mon, 07 Nov 2016 19:05:40 +1100 |
| |
Joe Perches <joe@perches.com> writes: > On Thu, 2016-11-03 at 15:58 -0400, David Miller wrote: >> From: Madalin Bucur <madalin.bucur@nxp.com> >> Date: Wed, 2 Nov 2016 22:17:26 +0200 >> >> > This introduces the Freescale Data Path Acceleration Architecture >> > +static inline size_t bpool_buffer_raw_size(u8 index, u8 cnt) >> > +{ >> > + u8 i; >> > + size_t res = DPAA_BP_RAW_SIZE / 2; >> >> Always order local variable declarations from longest to shortest line, >> also know as Reverse Christmas Tree Format. > > I think this declaration sorting order is misguided but > here's a possible change to checkpatch adding a test for it > that does this test just for net/ and drivers/net/
And arch/powerpc too please.
cheers
| |