lkml.org 
[lkml]   [2016]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/2] x86/AMD: Fix cpu_llc_id for AMD Fam17h systems

* Borislav Petkov <bp@suse.de> wrote:

> On Mon, Nov 07, 2016 at 08:31:21AM +0100, Ingo Molnar wrote:
> > > cpu_llc_id (Last Level Cache ID) derivation on AMD Fam17h has an
> > > underflow bug when extracting the socket_id value. It starts from 0
>
> How's this...
>
> > > so subtracting 1 from it will result in an invalid value. This breaks
> > > scheduling topology later on since the cpu_llc_id will be incorrect.
> ^^^^^^^^^^^^^^^^^^^
> ... here?
>
> > Same question as for the previous patch: what are the effects of the bug:
>
> See above.

There's many ways the scheduling topology can 'break', resulting in different
effects:

- scheduling domains might be mixed up to the extent of crashing the bootup

- some cores might be missing altogether, reducing available CPUs in essence

- cache domains might be seriously mixed up, resulting in serious drop in
performance.

- or domains might be partitioned 'wrong' but not catastrophically
wrong, resulting in a minor performance drop (if at all)

... do we know which of these occurs in this situation?

Thanks,

Ingo

\
 
 \ /
  Last update: 2016-11-07 15:09    [W:1.201 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site