Messages in this thread | | | Date | Mon, 7 Nov 2016 13:00:27 +0100 | From | Thierry Reding <> | Subject | Re: [PATCH] drm/tegra: dpaux: Fix error handling |
| |
On Fri, Oct 28, 2016 at 11:09:45AM +0200, Christophe JAILLET wrote: > 'devm_pinctrl_register()' returns an error pointer or a valid handle. So > checking for NULL here is pointless and can never trigger. > > Check the returned value with IS_ERR instead and propagate this value as > done in the other functions which call 'devm_pinctrl_register()' > > Fixes: 0751bb5c44fe ("drm/tegra: dpaux: Add pinctrl support") > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/gpu/drm/tegra/dpaux.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Thierry [unhandled content-type:application/pgp-signature] | |