Messages in this thread | | | Subject | Re: [PATCH] net: 3com: typhoon: fix typhoon_get_link_ksettings | From | Sergei Shtylyov <> | Date | Sun, 6 Nov 2016 12:53:57 +0300 |
| |
Hello.
On 11/5/2016 6:11 PM, Philippe Reynes wrote:
> When moving from typhoon_get_settings to typhoon_getlink_ksettings > in the commit commit f7a5537cd2a5 ("net: 3com: typhoon: use new api
One "commit" is enough. :-)
> ethtool_{get|set}_link_ksettings"), we use a local variable supported > but we forgot to update the struct ethtool_link_ksettings with > this value. > > We also initialize advertising to zero, because otherwise it may > be uninitialized if no case of the switch (tp->xcvr_select) is used. > > Signed-off-by: Philippe Reynes <tremyfr@gmail.com> [...]
MBR, Sergei
| |