Messages in this thread | | | Subject | Re: Coding Style: Reverse XMAS tree declarations ? (was Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet) | From | Randy Dunlap <> | Date | Fri, 4 Nov 2016 10:05:15 -0700 |
| |
On 11/03/16 23:53, Joe Perches wrote: > On Thu, 2016-11-03 at 15:58 -0400, David Miller wrote: >> From: Madalin Bucur <madalin.bucur@nxp.com> >> Date: Wed, 2 Nov 2016 22:17:26 +0200 >> >>> This introduces the Freescale Data Path Acceleration Architecture >>> +static inline size_t bpool_buffer_raw_size(u8 index, u8 cnt) >>> +{ >>> + u8 i; >>> + size_t res = DPAA_BP_RAW_SIZE / 2; >> >> Always order local variable declarations from longest to shortest line, >> also know as Reverse Christmas Tree Format. > > I think this declaration sorting order is misguided but > here's a possible change to checkpatch adding a test for it > that does this test just for net/ and drivers/net/
I agree with the misguided part. That's not actually in CodingStyle AFAICT. Where did this come from?
thanks. -- ~Randy
| |