lkml.org 
[lkml]   [2016]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] MIPS: VDSO: Always select -msoft-float
On Fri, 4 Nov 2016, Guenter Roeck wrote:

> > As above, unless absolutely critical to have floating point code then
> > the vDSO should just avoid all FP related issues and build soft-float.
>
> FWIW, my logic was quite simple: The rest of the kernel builds with
> -msoft-float, thus vDSO should do the same. Of course, I don't know the
> entire context, so there may well be a reason to handle it differently
> than the rest of the kernel.

VDSO is not a part of the kernel, it's user mode code, made visible in
the user virtual memory, and implicitly loaded along the rest of the DSOs
on program startup by the dynamic loader (ld.so). It has to be PIC for
that reason, too, causing all the hassle we had with making it such that
it does not need a GOT.

> Anyway, isn't the kernel supposed to not use floating point operations
> in the first place ? Is this different for vDSO ?

This code is executed in the user mode so while floating-point code may
not be needed there, not at least right now, there's actually nothing
which should stop us from from adding some should such a need arise.

Maciej

\
 
 \ /
  Last update: 2016-11-04 17:10    [W:0.077 / U:1.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site