Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 4 Nov 2016 15:40:53 +0100 | Subject | Re: [PATCH 4/9] pinctrl: meson: allow gpio to request irq |
| |
On Wed, Oct 26, 2016 at 5:50 PM, Kevin Hilman <khilman@baylibre.com> wrote:
>> Yes they are all wrong. They should all be using irq_find_mapping(). > > So, dumb question from someone trying (but having a hard time) to follow > and understand the rationale... > > If it's wrong enough to completely reject, why are changes still being > merged that are doing it so wrong? (e.g. like this one[1], just merged > for v4.9)
It's a bug.
It's that problem that Wolfram brought up in a recent lecture about maintainer scaling: if noone but the subsystem maintainer reviews the code, things like this will happen.
I need more review...
> [1] 0eb9f683336d pinctrl: Add IRQ support to STM32 gpios > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/pinctrl/stm32/pinctrl-stm32.c?id=0eb9f683336d7eb99a3b75987620417c574ffb57
Alexandre, Maxime: can you please make a patch for the STM32 driver that remove the semantic dependence for .to_irq() to be called before an interrupt can be used? It should be possible to use the irqs directly from the irqchip.
Yours, Linus Walleij
| |