lkml.org 
[lkml]   [2016]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] vfio: Fix handling of error returned by 'vfio_group_get_from_dev()'
On Wed, 30 Nov 2016 21:27:07 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> On Wed, Nov 30, 2016 at 09:36:46AM -0700, Alex Williamson wrote:
> > On Wed, 30 Nov 2016 08:06:12 +0100
> > Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> >
> > > 'vfio_group_get_from_dev()' seems to return only NULL on error, not an error
> > > pointer.
> > >
> > > Fixes: 2169037dc322 ("vfio iommu: Added pin and unpin callback functions to vfio_iommu_driver_ops")
> > > Fixes: c086de818dd8 ("vfio iommu: Add blocking notifier to notify DMA_UNMAP")
> > >
> > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > > ---
> >
> > Dan Carpenter proposed a nearly identical patch:
> >
> > http://www.spinics.net/lists/kvm/msg141468.html
> >
> > The difference is you return -ENODEV while Dan returns -EINVAL. I tend
> > to prefer -ENODEV to distinguish this error case versus validation of
> > the other parameters. This patch also identifies both commits
> > introducing these, so I'm inclined to take this one rather than Dan's
> > version. Dan & Kirti, I welcome any credits you'd like to apply to
> > this patch for identifying and reviewing the same issue. Thanks,
> >
>
> Could I get a Reported-by?

Sure thing, thanks,

Alex

\
 
 \ /
  Last update: 2016-11-30 19:40    [W:0.069 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site