lkml.org 
[lkml]   [2016]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/6] g_NCR5380: Add IRQ auto-configuration for HP C2502

On Thu, 3 Nov 2016, Ondrej Zary wrote:

> On Thursday 03 November 2016, Finn Thain wrote:
> > On Wed, 2 Nov 2016, Ondrej Zary wrote:
> > >
> > > The card is almost Plug&Play. The base address is already configured
> > > automatically by the driver so doing the same for IRQ makes sense.
> >
> > Why don't we see any other drivers doing this?
>
> Many ISA sound card drivers do this - there's even a function for this:
> static int snd_legacy_find_free_irq(int *irq_table)

Well, if snd_legacy_find_free_irq() is good enough for the ALSA
maintainers, it is good enough for me.

But I still don't like this patch. I would prefer to cut-and-paste
snd_legacy_find_free_irq() as g_NCR5380_find_free_irq(), and
snd_legacy_empty_irq_handler() as g_NCR5380_empty_irq_handler(), to allow
for refactoring all that into a common header file later on.

When the user asks for board == BOARD_HP_C2502 and irq == IRQ_AUTO, just
use the first result from g_NCR5380_find_free_irq() to program the card.
If no irq is free, program the card for irq 0.

Then just proceed with the usual IRQ_AUTO probing, like you would for any
other board. That way, there is no need for NCR5380_test_irq() at all, and
you can drop patch 2/5 (at least until we figure out why a command timeout
during modprobe hangs your system).

--

\
 
 \ /
  Last update: 2016-11-04 04:01    [W:0.087 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site