Messages in this thread | | | Date | Thu, 3 Nov 2016 21:26:46 +0000 | From | Matt Fleming <> | Subject | Re: [PATCH] x86/boot: Remove always empty $(USERINCLUDE) |
| |
On Thu, 03 Nov, at 10:51:38AM, Paul Bolle wrote: > Apparently Matt left Intel. Let's forward this to a recently used > address. > > On Thu, 2016-11-03 at 10:47 +0100, Paul Bolle wrote: > > Commmit b6eea87fc685 ("x86, boot: Explicitly include autoconf.h for > > hostprogs") correctly noted > > [...] that because $(USERINCLUDE) isn't exported by > > the top-level Makefile it's actually empty in arch/x86/boot/Makefile. > > > > So let's do the sane thing and remove the reference to that make variable. > > > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > > --- > > arch/x86/boot/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile > > index 12ea8f8384f4..0d810fb15eac 100644 > > --- a/arch/x86/boot/Makefile > > +++ b/arch/x86/boot/Makefile > > @@ -65,7 +65,7 @@ clean-files += cpustr.h > > > > # --------------------------------------------------------------------------- > > > > -KBUILD_CFLAGS := $(USERINCLUDE) $(REALMODE_CFLAGS) -D_SETUP > > +KBUILD_CFLAGS := $(REALMODE_CFLAGS) -D_SETUP > > KBUILD_AFLAGS := $(KBUILD_CFLAGS) -D__ASSEMBLY__ > > GCOV_PROFILE := n > > UBSAN_SANITIZE := n
Looks OK to me.
Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>
| |