lkml.org 
[lkml]   [2016]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 3/3] ovl: redirect on rename-dir
On Fri, Oct 28, 2016 at 6:15 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Tue, Oct 25, 2016 at 09:34:47AM +0200, Miklos Szeredi wrote:
>> Current code returns EXDEV when a directory would need to be copied up to
>> move. We could copy up the directory tree in this case, but there's
>> another solution: point to old lower directory from moved upper directory.
>>
>> This is achieved with a "trusted.overlay.redirect" xattr storing the path
>> relative to the root of the overlay. After such attribute has been set,
>> the directory can be moved without further actions required.
>>
>> This is a backward incompatible feature, old kernels won't be able to
>> correctly mount an overlay containing redirected directories.
>
>> + err = vfs_path_lookup(lowerpath.dentry, lowerpath.mnt,
>> + redirect, 0, &thispath);
>> +
>> + if (err) {
>> + if (err == -ENOENT || err == -ENAMETOOLONG)
>> + this = NULL;
>> + } else {
>> + this = thispath.dentry;
>> + mntput(thispath.mnt);
>> + if (!this->d_inode) {
>> + dput(this);
>> + this = NULL;
>> + } else if (ovl_dentry_weird(this)) {
>> + dput(this);
>> + err = -EREMOTE;
>> + }
>> + }
>
> I'm not happy with that one - you are relying upon the fairly subtle
> assertions here.
> 1) Had lowerpath.mnt *not* been a privately cloned one with nothing
> mounted on it, you would've been screwed.
> 2) Had that thing contained a "jumper" symlink (a-la procfs ones),
> you would've been screwed. Currently only procfs has those, and it would've
> been rejected before getting there, but this is brittle and non-obvious.
> 3) Any automount point in there (nfs4 referrals, etc.) can
> break the assumption that nothing could've been mounted on it. And _that_
> might have not been stepped onto; back when the path had been stored, there'd
> been no automount point at all, so we have avoided ovl_dentry_weird() rejects,
> and by now nothing on the path had been visited yet, so ovl_dentry_weird()
> didn't have a chance to trigger. Note that calling it on the last dentry
> is no good - we might have crossed the automount point in the middle of that
> path, so this last dentry might be nice and shiny - and on another filesystem.
> So unlike (1) and (2) it's not just a fishy-looking thing that happens to
> work for non-local reasons; AFAICS, it's actually a bug.
>
> I'm not sure if vfs_path_lookup() is the right tool here. It might be
> usable for making such a tool, but as it is you are setting one hell of
> a trap for yourself...

Agreed, it's not the right tool. A custom loop of lookup_one_len's
should work much better and doesn't add all that much complexity.
Updated patch pushed to:

git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git #redirect

This version also passes the recycling tests by Amir and enables the
redirect feature by default on an empty upperdir.

Thanks,
Miklos

\
 
 \ /
  Last update: 2016-11-03 16:51    [W:0.197 / U:29.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site