Messages in this thread | | | Date | Tue, 29 Nov 2016 16:20:12 +0100 | From | Michal Hocko <> | Subject | Re: [PATCH 08/22 v2] mm/vmstat: Avoid on each online CPU loops |
| |
On Tue 29-11-16 15:51:14, Sebastian Andrzej Siewior wrote: > Both iterations over online cpus can be replaced by the proper node > specific functions. > > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Vlastimil Babka <vbabka@suse.cz> > Cc: Mel Gorman <mgorman@techsingularity.net> > Cc: Johannes Weiner <hannes@cmpxchg.org> > Cc: linux-mm@kvack.org > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Michal Hocko <mhocko@suse.com>
> --- > v1…v2: take into account that we may have online nodes with no CPUs. > > mm/vmstat.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 0b63ffb5c407..5152cd1c490f 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1720,19 +1720,21 @@ static void __init start_shepherd_timer(void) > > static void __init init_cpu_node_state(void) > { > - int cpu; > + int node; > > - for_each_online_cpu(cpu) > - node_set_state(cpu_to_node(cpu), N_CPU); > + for_each_online_node(node) { > + if (cpumask_weight(cpumask_of_node(node)) > 0) > + node_set_state(node, N_CPU); > + } > } > > static void vmstat_cpu_dead(int node) > { > - int cpu; > + const struct cpumask *node_cpus; > > - for_each_online_cpu(cpu) > - if (cpu_to_node(cpu) == node) > - return; > + node_cpus = cpumask_of_node(node); > + if (cpumask_weight(node_cpus) > 0) > + return; > > node_clear_state(node, N_CPU); > } > -- > 2.10.2
-- Michal Hocko SUSE Labs
| |