Messages in this thread Patch in this message | | | From | Maninder Singh <> | Subject | [PATCH 1/1] scripts: Fixing NULL pointer dereference when pos->file is NULL | Date | Tue, 29 Nov 2016 16:04:59 +0530 |
| |
This patch fixes NULL pointer dereference when pos->file is NULL.
caught with static analysis tool. Signed-off-by: Maninder Singh <maninder1.s@samsung.com> Signed-off-by: Vaneet Narang <v.narang@samsung.com> --- scripts/dtc/srcpos.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/scripts/dtc/srcpos.c b/scripts/dtc/srcpos.c index f534c22..360fd14 100644 --- a/scripts/dtc/srcpos.c +++ b/scripts/dtc/srcpos.c @@ -252,12 +252,11 @@ struct srcpos * srcpos_dump(struct srcpos *pos) { printf("file : \"%s\"\n", - pos->file ? (char *) pos->file : "<no file>"); + pos->file ? pos->file->name : "<no file>"); printf("first_line : %d\n", pos->first_line); printf("first_column: %d\n", pos->first_column); printf("last_line : %d\n", pos->last_line); printf("last_column : %d\n", pos->last_column); - printf("file : %s\n", pos->file->name); } -- 1.9.1
| |