Messages in this thread | | | Subject | Re: [PATCH] GenWQE: drop duplicate headers | From | Frank Haverkamp <> | Date | Thu, 24 Nov 2016 13:51:57 +0100 |
| |
Hi Geliang,
> On 23 Nov 2016, at 15:24, Geliang Tang <geliangtang@gmail.com> wrote: > > Drop duplicate headers module.h and delay.h. > > Signed-off-by: Geliang Tang <geliangtang@gmail.com> > --- > drivers/misc/genwqe/card_base.c | 1 - > drivers/misc/genwqe/card_ddcb.c | 1 - > drivers/misc/genwqe/card_utils.c | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c > index 6c1f49a..b6f2edf 100644 > --- a/drivers/misc/genwqe/card_base.c > +++ b/drivers/misc/genwqe/card_base.c > @@ -34,7 +34,6 @@ > #include <linux/wait.h> > #include <linux/delay.h> > #include <linux/dma-mapping.h> > -#include <linux/module.h> > #include <linux/notifier.h> > #include <linux/device.h> > #include <linux/log2.h> > diff --git a/drivers/misc/genwqe/card_ddcb.c b/drivers/misc/genwqe/card_ddcb.c > index ddfeefe..332a0d1 100644 > --- a/drivers/misc/genwqe/card_ddcb.c > +++ b/drivers/misc/genwqe/card_ddcb.c > @@ -34,7 +34,6 @@ > #include <linux/string.h> > #include <linux/dma-mapping.h> > #include <linux/delay.h> > -#include <linux/module.h> > #include <linux/interrupt.h> > #include <linux/crc-itu-t.h> > > diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c > index 147b830..a1859e5 100644 > --- a/drivers/misc/genwqe/card_utils.c > +++ b/drivers/misc/genwqe/card_utils.c > @@ -36,7 +36,6 @@ > #include <linux/ctype.h> > #include <linux/module.h> > #include <linux/platform_device.h> > -#include <linux/delay.h> > #include <asm/pgtable.h> > > #include "genwqe_driver.h" > -- > 2.9.3 >
thanks for the simplification. Did you find those by manual inspection, or did you use a tool?
Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
| |