Messages in this thread | | | From | David Matlack <> | Date | Mon, 28 Nov 2016 11:51:09 -0800 | Subject | Re: [PATCH 2/4] KVM: nVMX: fix checks on CR{0,4} during virtual VMX operation |
| |
On Wed, Nov 23, 2016 at 3:31 AM, Paolo Bonzini <pbonzini@redhat.com> wrote: > On 23/11/2016 02:14, David Matlack wrote: >> +static bool fixed_bits_valid(u64 val, u64 fixed0, u64 fixed1) >> +{ >> + return ((val & fixed0) == fixed0) && ((~val & ~fixed1) == ~fixed1); >> +} >> + > > This is the same as vmx_control_verify (except with u64 arguments > instead of u32).
Good point. I'll remove this duplication in v3.
| |