Messages in this thread | | | Date | Sun, 27 Nov 2016 22:25:28 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH] ARM: dts: mvebu: Fix armada-385-turris-omnia stdout-path |
| |
On Sun, Nov 27, 2016 at 08:37:24PM +0100, Andreas Färber wrote: > Specify the baudrate. > > Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia") > Cc: Uwe Kleine-König <uwe@kleine-koenig.org> > Signed-off-by: Andreas Färber <afaerber@suse.de>
You said with plain &uart0 the kernel uses a wrong baud rate? That's strange. For me it works and I think it's the intended behaviour to dermine the baud rate setup by the bootloader and use this.
I'd prefer it this way over hard coding the baud rate.
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts > index f53cb8b73610..2eff012287d4 100644 > --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts > +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts > @@ -52,7 +52,7 @@ > compatible = "cznic,turris-omnia", "marvell,armada385", "marvell,armada380"; > > chosen { > - stdout-path = &uart0; > + stdout-path = "serial0:115200n8"; > }; > > memory {
This has the downside to depend on the alias. Not sure this is considered modern. An alternative would be:
stdout-path = "/soc/internal-regs/serial@12000:115200n8";
(maybe there even exists syntactic sugar to express this using &uart0?)
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
| |