| From | Sebastian Andrzej Siewior <> | Subject | [PATCH 03/22] idle/intel: Remove superfluous SMP fuction call | Date | Sun, 27 Nov 2016 00:13:31 +0100 |
| |
From: Anna-Maria Gleixner <anna-maria@linutronix.de>
Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to hotplugged cpu") the CPU_ONLINE and CPU_DOWN_PREPARE notifiers are always run on the hot plugged CPU, and as of commit 3b9d6da67e11 ("cpu/hotplug: Fix rollback during error-out in __cpu_disable()") the CPU_DOWN_FAILED notifier also runs on the hot plugged CPU. This patch converts the SMP functional calls into direct calls.
smp_function_call_single() executes the function with interrupts disabled. This calling convention is not preserved, because tick_broadcast_enable() and tick_braodcast_disable() handle interrupts themselves.
Cc: Len Brown <lenb@kernel.org> Cc: linux-pm@vger.kernel.org Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- drivers/idle/intel_idle.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c index 4466a2f969d7..f53b42a78186 100644 --- a/drivers/idle/intel_idle.c +++ b/drivers/idle/intel_idle.c @@ -927,8 +927,7 @@ static int cpu_hotplug_notify(struct notifier_block *n, case CPU_ONLINE: if (lapic_timer_reliable_states != LAPIC_TIMER_ALWAYS_RELIABLE) - smp_call_function_single(hotcpu, __setup_broadcast_timer, - (void *)true, 1); + __setup_broadcast_timer((void *)true); /* * Some systems can hotplug a cpu at runtime after -- 2.10.2
|