Messages in this thread | | | Date | Fri, 25 Nov 2016 19:52:23 -0500 (EST) | Subject | Re: [PATCH RFC] hlist_add_tail_rcu disable sparse warning | From | David Miller <> |
| |
From: "Michael S. Tsirkin" <mst@redhat.com> Date: Wed, 23 Nov 2016 22:48:19 +0200
> I would appreciate review to confirm the function doesn't > do anything unsafe though. > > In particular, should this use __hlist_for_each_rcu instead? > I note that __hlist_for_each_rcu does rcu_dereference > internally, which is missing here.
I personally think it should use __hlist_for_each_rcu, otherwise nothing expresses the rcu-ness of the operation.
| |