lkml.org 
[lkml]   [2016]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] staging: lustre: osc: Performance tune for LRU
On Wed, Nov 23, 2016 at 06:01:45PM -0500, James Simmons wrote:
> From: Jinshan Xiong <jinshan.xiong@intel.com>
>
> Early launch page LRU work in osc_io_rw_iter_init();
> Change the page LRU shrinking policy by OSC attributes;
> Delete the contented lock osc_object::oo_seatbelt
>

The cli_name() stuff should be in a separate patch. It's hard to review
this stuff (or possibly I just found the first deal breaker and gave
up).

Anyway, please review this again and break it up into separate patches.

regards,
dan carpenter

PS: I glanced at the patch again and the very first line is changing
"lru" to "LRU" in a comment. We'll get a million performance increases
from that I bet. Don't mix random white space changes into it...


\
 
 \ /
  Last update: 2016-11-25 23:13    [W:0.038 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site