Messages in this thread | | | Date | Fri, 25 Nov 2016 12:38:13 -0700 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array |
| |
On Fri, Nov 25, 2016 at 10:08:38AM +0200, Jarkko Sakkinen wrote:
> > This is no good at this point in the series - we need the ENODEV > > detection in tpm_chip_register() from the 'Fix handle of missing event > > log' moved into this patch, because it now returns ENODEV due to > > sercurityfs > > Sure it would be cleaner but not really necessary. Do you really think > this is mandatory? No matter how I reorder patches this will require > time and effort to fix various merge conflicts because of the replacemnt > of event log. After that I have to test everything.
Well, once you started editing patches to fix them you should make them fully correct so bisection works.
If you applied the patch I gave you on top of the tree then I would have said to leave it...
> The commit message otherwise great except for the short summary, which > is now fixed.
It is good now
Jason
| |