Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS | Date | Fri, 25 Nov 2016 09:30:07 +0100 |
| |
On Friday, November 25, 2016 8:50:04 AM CET Robin van der Gracht wrote: > > Thanks for reporting this. You are right about the missing helper. > However, the fb_ops struct uses several helpers which are all missing. > > static struct fb_ops ht16k33_fb_ops = { > .owner = THIS_MODULE, > .fb_read = fb_sys_read, > .fb_write = fb_sys_write, > .fb_fillrect = sys_fillrect, > .fb_copyarea = sys_copyarea, > .fb_imageblit = sys_imageblit, > .fb_mmap = ht16k33_mmap, > }; > > HT16K33 should also select: > FB_CFB_FILLRECT > FB_CFB_COPYAREA > FB_CFB_IMAGEBLIT >
Ah right. I had not run into those so far during randconfig testing, probably because there is usually at least one other framebuffer enabled that selects them.
Can you submit a patch to add all those?
Arnd
| |