lkml.org 
[lkml]   [2016]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regulator: twl6030: add dependency on OF
On Fri, Nov 25, 2016 at 03:09:43PM +0200, Nicolae Rosia wrote:
> On Fri, Nov 25, 2016 at 3:03 PM, Mark Brown <broonie@kernel.org> wrote:

> >> - .of_match_table = of_match_ptr(twl_of_match),
> >> + .of_match_table = twl_of_match,

> > This buys us nothing, it's not going to make any practical difference
> > but on the other hand it costs nothing to have it there either. The
> > only impact I can see this having is causing someone doing a cut'n'paste
> > to miss the of_match_ptr() out.

> I did this because I received a comment on another patch [0].

OK, but that still doesn't really explain what the benefit is!
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-11-25 14:19    [W:0.042 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site