lkml.org 
[lkml]   [2016]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net v2 1/5] net: dsa: fix fixed-link-phy device leaks
    Date
    Make sure to drop the reference taken by of_phy_find_device() when
    registering and deregistering the fixed-link PHY-device.

    Fixes: 39b0c705195e ("net: dsa: Allow configuration of CPU & DSA port
    speeds/duplex")
    Signed-off-by: Johan Hovold <johan@kernel.org>
    ---
    net/dsa/dsa.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
    index a6902c1e2f28..cb0091b99592 100644
    --- a/net/dsa/dsa.c
    +++ b/net/dsa/dsa.c
    @@ -233,6 +233,8 @@ int dsa_cpu_dsa_setup(struct dsa_switch *ds, struct device *dev,
    genphy_read_status(phydev);
    if (ds->ops->adjust_link)
    ds->ops->adjust_link(ds, port, phydev);
    +
    + put_device(&phydev->mdio.dev);
    }

    return 0;
    @@ -509,8 +511,9 @@ void dsa_cpu_dsa_destroy(struct device_node *port_dn)
    if (of_phy_is_fixed_link(port_dn)) {
    phydev = of_phy_find_device(port_dn);
    if (phydev) {
    - phy_device_free(phydev);
    fixed_phy_unregister(phydev);
    + put_device(&phydev->mdio.dev);
    + phy_device_free(phydev);
    }
    }
    }
    --
    2.7.3
    \
     
     \ /
      Last update: 2016-11-24 19:25    [W:2.528 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site