lkml.org 
[lkml]   [2016]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.8 63/67] IB/uverbs: Fix leak of XRC target QPs
    Date
    4.8-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Tariq Toukan <tariqt@mellanox.com>

    commit 5b810a242c28e1d8d64d718cebe75b79d86a0b2d upstream.

    The real QP is destroyed in case of the ref count reaches zero, but
    for XRC target QPs this call was missed and caused to QP leaks.

    Let's call to destroy for all flows.

    Fixes: 0e0ec7e0638e ('RDMA/core: Export ib_open_qp() to share XRC...')
    Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
    Signed-off-by: Noa Osherovich <noaos@mellanox.com>
    Signed-off-by: Leon Romanovsky <leon@kernel.org>
    Signed-off-by: Doug Ledford <dledford@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/infiniband/core/uverbs_main.c | 7 ++-----
    1 file changed, 2 insertions(+), 5 deletions(-)

    --- a/drivers/infiniband/core/uverbs_main.c
    +++ b/drivers/infiniband/core/uverbs_main.c
    @@ -262,12 +262,9 @@ static int ib_uverbs_cleanup_ucontext(st
    container_of(uobj, struct ib_uqp_object, uevent.uobject);

    idr_remove_uobj(&ib_uverbs_qp_idr, uobj);
    - if (qp != qp->real_qp) {
    - ib_close_qp(qp);
    - } else {
    + if (qp == qp->real_qp)
    ib_uverbs_detach_umcast(qp, uqp);
    - ib_destroy_qp(qp);
    - }
    + ib_destroy_qp(qp);
    ib_uverbs_release_uevent(file, &uqp->uevent);
    kfree(uqp);
    }

    \
     
     \ /
      Last update: 2016-11-24 16:36    [W:4.637 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site