Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC | Date | Thu, 24 Nov 2016 12:09:41 +0100 |
| |
On Thursday, November 24, 2016 6:57:18 PM CET Ziji Hu wrote: > > > > Please explain in the changelog why this is not a generic > > phy driver (or three of them). > > > Actually we tried to put the PHY code into Linux PHY framework. > But it cannot fit in Linux common PHY framework. > > Our Xenon SDHC PHY register is a part of Xenon SDHC register set. > Besides, during MMC initialization, MMC sequence has to call several PHY functions to complete timing setting. > In those PHY setting functions, they have to access SDHC register and know current MMC setting, such as bus width, clock frequency and speed mode. > As a result, we have to implement PHY under MMC directory. >
Ok, that makes sense, just put the same text in the changelog comment.
Arnd
| |