lkml.org 
[lkml]   [2016]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure"
From
Date
On Tue, 2016-11-22 at 11:37 -0800, Brian Norris wrote:
> On Fri, Oct 28, 2016 at 11:51:47AM -0700, Joe Perches wrote:
> > I'd suggest as well fixing all the dev_<level> uses
> > to be a consistent form: (this also fixes the typo)
> > and a few other bits
> >
> > o Coalesce formats
> > o Realign arguments
> > o Add missing newlines
>
> Yeah, Colin missed this on the line he was fixing.
>
> > o Convert printk(KERN_<LEVEL> to pr_<level>(
> > o Add #define pr_fmt, remove MTDSWAP_PREFIX
> >
> > Reduces object size a little too
>
> Thanks, these all look good but:
>
> (a) you didn't provide a Signed-off-by and
> (b) your patch is full of non-breaking spaces (0xA0), instead of proper
> ASCII spaces (0x20)
>
> I feel like we've had this conversation before about your Evolution
> mailer a long time ago; you still haven't fixed that?
>
> I'm sorry, but I just can't take your patch. I'm not going to hand-edit
> this one...

No worries, it was an unsigned patch suggestion, not
a formal patch. I know the difference.

And have you ever looked at the evolution source code?
At best, it's pretty convoluted.
There's _no way_ I want to touch it.

\
 
 \ /
  Last update: 2016-11-22 22:34    [W:0.057 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site