lkml.org 
[lkml]   [2016]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] proc: calculate /proc/* and /proc/*/task/* nlink at init time
On 22 November 2016 at 20:55, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> Runtime nlink calculation works but meh. I don't know how to do it
> at compile time, but I know how to do it at init time.
>
> Shift "2+" part into init time as a bonus.

Couple of small suggestions:

- rename set_proc_pid_nlink() to proc_pid_nlink_init() to make it 100%
clear it's a one time thing

- move pid_entry_nlink() down to just above where it is called

Either way,

Acked-by/Reviewed-by: Vegard Nossum <vegard.nossum@oracle.com>


Vegard

\
 
 \ /
  Last update: 2016-11-22 19:43    [W:0.045 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site