lkml.org 
[lkml]   [2016]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 3/3] ARM: davinci: hawk: use gpio descriptor for card detect
    From
    Date
    On Monday 21 November 2016 09:45 PM, Axel Haslam wrote:
    > Currently the mmc driver is polling the gpio to know if the
    > card was removed.
    >
    > By using a gpio descriptor instead of the platform callbacks, the
    > driver will be able to register the gpio with the mmc core with API's
    > designed for this purpose.
    >
    > This has the advantage that an irq will be registered,
    > and polling is no longer needed. Also, platform callbacks can be removed.
    >
    > Signed-off-by: Axel Haslam <ahaslam@baylibre.com>

    This patch looks good, provided it is not based of 1/3 and 2/3. There
    are other boards in mach-davinci using the card detect and wp callbacks.
    And some like board-dm365-evm.c have those pins routed through a CPLD.
    So I guess there is more work to be done before platform callbacks can
    completely be removed from MMC/SD driver. But the closer we get, the
    better it is :)

    Thanks,
    Sekhar

    \
     
     \ /
      Last update: 2016-11-22 11:27    [W:4.324 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site