lkml.org 
[lkml]   [2016]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/2] of: base: add support to get machine model name
    From
    Date
    On 11/21/16 11:24, Frank Rowand wrote:
    > On 11/21/16 08:23, Sudeep Holla wrote:
    >>
    >>
    >> On 21/11/16 16:05, Frank Rowand wrote:
    >>> Hi Sudeep,
    >>>
    >>> On 11/18/16 12:22, Frank Rowand wrote:
    >>>> On 11/18/16 02:41, Sudeep Holla wrote:
    >>>>>
    >>>>>
    >>>>> On 17/11/16 21:00, Frank Rowand wrote:
    >>>>>> On 11/17/16 07:32, Sudeep Holla wrote:
    >>>>>>> Currently platforms/drivers needing to get the machine model name are
    >>>>>>> replicating the same snippet of code. In some case, the OF reference
    >>>>>>> counting is either missing or incorrect.
    >>>>>>>
    >>>>>>> This patch adds support to read the machine model name either using
    >>>>>>> the "model" or the "compatible" property in the device tree root node
    >>>>>>> to the core OF/DT code.
    >>>>>>>
    >>>>>>> This can be used to remove all the duplicate code snippets doing exactly
    >>>>>>> same thing later.
    >>>>>>
    >>>>>> I find five instances of reading only property "model":
    >>>>>>
    >>>>>> arch/arm/mach-imx/cpu.c
    >>>>>> arch/arm/mach-mxs/mach-mxs.c
    >>>>>> arch/c6x/kernel/setup.c
    >>>>>> arch/mips/cavium-octeon/setup.c
    >>>>>> arch/sh/boards/of-generic.c
    >>>>>>
    >>>>>
    >>>>> Ah sorry you were not Cc-ed in 2/2, but that shows all the instances
    >>>>> that this will be used for.
    >>>>
    >>>> I have not seen 2/2. I do not see it on the devicetree list or on lkml.
    >>>
    >>> Can you please re-send patch 2/2?
    >>>
    >>
    >> Since it is based on -next, I would prefer to wait until next merge
    >> window to resend. You should be able to check in the link I sent if
    >> that's OK.
    >
    > I am missing or misunderstanding something.
    >
    > I do not know what "the link I sent" means.

    Ah, the links were in the email you sent before this one, but I read this
    one first. Got it now.


    >
    > For some reason, the devicetree mail list and lmkl mail failed to send
    > me a copy of patch 2/2. Or my mail server failed to receive them. That
    > is why I asked you to resend the patch. I just now looked in the devicetree
    > archive and found it there.
    >
    > So I now can see how you plan to use the new function.
    >
    > -Frank
    >
    >
    >

    \
     
     \ /
      Last update: 2016-11-21 21:50    [W:2.451 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site