Messages in this thread | | | Subject | Re: [PATCH] xen-scsifront: Add a missing call to kfree | From | Juergen Gross <> | Date | Mon, 21 Nov 2016 07:01:36 +0100 |
| |
On 19/11/16 19:22, Quentin Lambert wrote: > Most error branches following the call to kmalloc contain > a call to kfree. This patch add these calls where they are > missing. > > This issue was found with Hector. > > Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Nice catch. I think this will need some more work, I'll do a follow-on patch.
Reviewed-by: Juergen Gross <jgross@suse.com>
> > --- > drivers/scsi/xen-scsifront.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/drivers/scsi/xen-scsifront.c > +++ b/drivers/scsi/xen-scsifront.c > @@ -627,6 +627,7 @@ static int scsifront_action_handler(stru > > if (scsifront_enter(info)) { > spin_unlock_irq(host->host_lock); > + kfree(shadow); > return FAILED; > } > >
| |