lkml.org 
[lkml]   [2016]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net 09/18] net/ena: change condition for host attribute configuration
    Date
    Move the host info config to be the first admin command that is executed.
    This change require the driver to remove the 'feature check'
    from host info configuration flow.
    The check is removed since the supported features bitmask field
    is retrieved only after calling ENA_ADMIN_DEVICE_ATTRIBUTES admin command.

    If set host info is not supported an error will be returned by the device.

    Signed-off-by: Netanel Belgazal <netanel@annapurnalabs.com>
    ---
    drivers/net/ethernet/amazon/ena/ena_com.c | 8 +++-----
    drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 +++--
    2 files changed, 6 insertions(+), 7 deletions(-)

    diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c
    index edb2e81..b2891f9 100644
    --- a/drivers/net/ethernet/amazon/ena/ena_com.c
    +++ b/drivers/net/ethernet/amazon/ena/ena_com.c
    @@ -2474,11 +2474,9 @@ int ena_com_set_host_attributes(struct ena_com_dev *ena_dev)

    int ret;

    - if (!ena_com_check_supported_feature_id(ena_dev,
    - ENA_ADMIN_HOST_ATTR_CONFIG)) {
    - pr_warn("Set host attribute isn't supported\n");
    - return -EPERM;
    - }
    + /* Host attribute config is called before ena_com_get_dev_attr_feat
    + * so ena_com can't check if the feature is supported.
    + */

    memset(&cmd, 0x0, sizeof(cmd));
    admin_queue = &ena_dev->admin_queue;
    diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
    index 44dc298..dd7c74b 100644
    --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
    +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
    @@ -2387,6 +2387,8 @@ static int ena_device_init(struct ena_com_dev *ena_dev, struct pci_dev *pdev,
    */
    ena_com_set_admin_polling_mode(ena_dev, true);

    + ena_config_host_info(ena_dev);
    +
    /* Get Device Attributes*/
    rc = ena_com_get_dev_attr_feat(ena_dev, get_feat_ctx);
    if (rc) {
    @@ -2411,11 +2413,10 @@ static int ena_device_init(struct ena_com_dev *ena_dev, struct pci_dev *pdev,

    *wd_state = !!(aenq_groups & BIT(ENA_ADMIN_KEEP_ALIVE));

    - ena_config_host_info(ena_dev);
    -
    return 0;

    err_admin_init:
    + ena_com_delete_host_info(ena_dev);
    ena_com_admin_destroy(ena_dev);
    err_mmio_read_less:
    ena_com_mmio_reg_read_request_destroy(ena_dev);
    --
    1.9.1
    \
     
     \ /
      Last update: 2016-11-20 09:51    [W:3.303 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site