Messages in this thread Patch in this message | | | From | Andreas Gruenbacher <> | Subject | [PATCH] Re: Problem with setxattr on sockfs with Smack after 971df15bd54ad46e907046ff33750a137b2f0096 | Date | Wed, 2 Nov 2016 20:34:21 +0100 |
| |
Casey,
does this patch help?
(The way how security xattrs are handled by LSM is pretty ugly. I'm not convinced that it doesn't break something else, yet.)
Thanks, Andreas --- fs/xattr.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/fs/xattr.c b/fs/xattr.c index 3368659..bf09836 100644 --- a/fs/xattr.c +++ b/fs/xattr.c @@ -183,11 +183,13 @@ int __vfs_setxattr_noperm(struct dentry *dentry, const char *name, security_inode_post_setxattr(dentry, name, value, size, flags); } - } else if (issec) { - const char *suffix = name + XATTR_SECURITY_PREFIX_LEN; - + } else { if (unlikely(is_bad_inode(inode))) return -EIO; + } + if (issec && error == -EOPNOTSUPP) { + const char *suffix = name + XATTR_SECURITY_PREFIX_LEN; + error = security_inode_setsecurity(inode, suffix, value, size, flags); if (!error) -- 2.7.4
| |