lkml.org 
[lkml]   [2016]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3] NFSv4: replace seqcount_t with a rw_semaphore
Date

> On Nov 2, 2016, at 13:11, Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
>
> On 2016-10-31 16:11:02 [+0000], Trond Myklebust wrote:
>>
>> Yes, and yes. We can’t rely on the list pointers remaining correct, so we restart the list scan and we use the ops->state_flag_bit to signal whether or not state has been recovered for the entry being scanned.
>
> but this is tested at the top of the loop and by then you look at
> lists' ->next pointer which might be invalid.
>

No. We ensure we restart the list scan if we release the spinlock. It’s safe…


\
 
 \ /
  Last update: 2016-11-02 18:38    [W:1.851 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site