lkml.org 
[lkml]   [2016]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/4] statx: Add a system call to make enhanced file info available
From
Date
On Fri, 2016-11-18 at 08:48 +0000, David Howells wrote:
> Jeff Layton <jlayton@redhat.com> wrote:
>
> >
> > >
> > > If neither AT_STATX_*_SYNC flag is set, the behaviour is the default for
> > > stat() on that filesystem.
> > >
> >
> > We also need to specify here what happens if both bits are set. Should
> > that be -EINVAL?
>
> Makes sense.
>
> This leads to another thought: should fstatat() be allowed to take AT_STATX_*
> flags?
>
> David

In principle, we could. fstatat currently rejects flags that it doesn't
understand with -EINVAL.

That said, I'd vote no -- if you wanted to change an application to
start setting these flags in fstatat calls, then it's just as simple to
convert it over to use statx. I don't see a lot of benefit in adding
that to a legacy syscall.

--
Jeff Layton <jlayton@redhat.com>

\
 
 \ /
  Last update: 2016-11-18 13:03    [W:1.488 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site