Messages in this thread | | | Date | Thu, 17 Nov 2016 21:40:43 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH] ARM: dts: sunxi: Explicitly enable pull-ups for MMC pins |
| |
On Thu, Nov 17, 2016 at 05:34:38PM +0800, Chen-Yu Tsai wrote: > In the past, all the MMC pins had > > allwinner,pull = <SUN4I_PINCTRL_NO_PULL>; > > which was actually a no-op. We were relying on U-boot to set the bias > pull up for us. These properties were removed as part of the fix up to > actually support no bias on the pins. During the transition some boards > experienced regular MMC time-outs during normal operation, while others > completely failed to initialize the SD card. > > Given that MMC starts in open-drain mode and the pull-ups are required, > it's best to enable it for all the pin settings. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Applied, thanks.
Maxime
-- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |