Messages in this thread | | | Subject | Re: [RFC][PATCH] cpufreq: intel_pstate: Support of energy performance hint using HWP | From | Srinivas Pandruvada <> | Date | Thu, 17 Nov 2016 11:31:32 -0800 |
| |
Hi Viresh, On Thu, 2016-11-17 at 12:19 +0530, Viresh Kumar wrote: > Hi Srinivas, > > I don't think other platforms need it for now and so it is fine to > add these to the driver itself. Good to know. In this case I will proceed with change only local to intel_pstate.
> > On 15-11-16, 14:59, Srinivas Pandruvada wrote: > > > > +static ssize_t show_energy_performance_available_preferences( > > Maybe a personal preference, but I would have broken the line after > ssize_t instead of where you have done it. I can change that.
> > > > > + struct cpufreq_policy *policy, > > char *buf) > > +{ > > +static struct freq_attr *hwp_cpufreq_attrs[] = { > > + &energy_performance_preference, > > + &energy_performance_available_preferences, > > + NULL, > > +}; > > What about adding these to intel_pstate_attr_group instead ? Sure.
Thanks, Srinivas
| |