Messages in this thread | | | Date | Thu, 17 Nov 2016 17:22:37 +0000 | From | Sudip Mukherjee <> | Subject | Re: [PATCH] mtd: nand: nandsim: fix error check |
| |
On Thursday 17 November 2016 01:21 PM, Marek Vasut wrote: > On 11/16/2016 09:56 PM, Sudip Mukherjee wrote: >> On Wednesday 16 November 2016 04:56 PM, Marek Vasut wrote: >>> On 11/16/2016 08:52 AM, Sudip Mukherjee wrote: >>>> On Tuesday 15 November 2016 11:42 PM, Marek Vasut wrote: >>>>> On 11/16/2016 12:09 AM, Sudip Mukherjee wrote: >>>>>> debugfs_create_dir() and debugfs_create_file() returns NULL on >>>>>> error or >>>>>> a pointer on success. They do not return the error value with ERR_PTR. >>>>>> So we should not check the return with IS_ERR_OR_NULL, instead we >>>>>> should just check for NULL. >>>>>> >>>>>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> >>>>>> --- >>>>>> drivers/mtd/nand/nandsim.c | 9 +++------ >>>>>> 1 file changed, 3 insertions(+), 6 deletions(-) >>>>>> >>>>>> diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c >>>>>> index c76287a..9b0d79a 100644 >>>>>> --- a/drivers/mtd/nand/nandsim.c >>>>>> +++ b/drivers/mtd/nand/nandsim.c >>>>>> @@ -525,15 +525,13 @@ static int nandsim_debugfs_create(struct >>>>>> nandsim *dev) >>>>>> { >>>>>> struct nandsim_debug_info *dbg = &dev->dbg; >>>>>> struct dentry *dent; >>>>>> - int err; >>>>>> + int err = -ENODEV; >>>>> >>>>> Why don't you just nuke the err altogether and just return -ENODEV ? >>>> >>>> That was the first version which i made and discarded before sending. I >>>> will go and find it now. >>> >>> Why did you discard it ? >>> >> >> That is actually a stupid reason. I was confused with the print >> statement which uses err. >> >> NS_ERR("cannot create \"nandsim\" debugfs directory, err %d\n", >> err); >> > > Ah, got it, so yeah, nuke the err altogether :)
v2 is already sent yesterday.
Regards Sudip
| |