Messages in this thread | | | Subject | Re: [v2] cw1200: fix bogus maybe-uninitialized warning | From | Kalle Valo <> | Date | Thu, 17 Nov 2016 06:48:19 +0000 (UTC) |
| |
Arnd Bergmann <arnd@arndb.de> wrote: > On x86, the cw1200 driver produces a rather silly warning about the > possible use of the 'ret' variable without an initialization > presumably after being confused by the architecture specific definition > of WARN_ON: > > drivers/net/wireless/st/cw1200/wsm.c: In function ‘wsm_handle_rx’: > drivers/net/wireless/st/cw1200/wsm.c:1457:9: error: ‘ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > > We have already checked that 'count' is larger than 0 here, so > we know that 'ret' is initialized. Changing the 'for' loop > into do/while also makes this clear to the compiler. > > Suggested-by: David Laight <David.Laight@ACULAB.COM> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied to wireless-drivers-next.git, thanks.
7fc1503c906f cw1200: fix bogus maybe-uninitialized warning
-- https://patchwork.kernel.org/patch/9395413/
Documentation about submitting wireless patches and checking status from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |