lkml.org 
[lkml]   [2016]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4.8 78/92] batman-adv: fix splat on disabling an interface
On Thu, Nov 17, 2016 at 11:51:24AM +0100, Sven Eckelmann wrote:
> On Donnerstag, 17. November 2016 11:32:51 CET Greg Kroah-Hartman wrote:
> > 4.8-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Linus Lüssing <linus.luessing@c0d3.blue>
> >
> > commit 9799c50372b23ed774791bdb87d700f1286ee8a9 upstream.
> >
> > As long as there is still a reference for a hard interface held, there might
> > still be a forwarding packet relying on its attributes.
> >
> > Therefore avoid setting hard_iface->soft_iface to NULL when disabling a hard
> > interface.
> >
> > This fixes the following, potential splat:
> >
> [...]
>
> Thanks for your backporting efforts. There is already a revert for this patch
> queued up in batadv/net [1] (targets net.git). So maybe you want to drop this
> patch from your stable queue.
>
> We also got test results from Linus which showed that this problem didn't
> happen anymore with recent kernel versions (without his patch). These results
> made him also Ack the revert.
>
> Sorry about this confusing situation.

Not a problem, I've dropped this one from the patch queue now, thanks
for letting me know.

greg k-h

\
 
 \ /
  Last update: 2016-11-17 13:03    [W:0.236 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site