Messages in this thread | | | Date | Thu, 17 Nov 2016 12:47:11 +0100 | From | Takashi Iwai <> | Subject | Re: [alsa-devel] sound: bebop: strncmp length oddity |
| |
On Sat, 29 Oct 2016 23:37:00 +0200, Joe Perches wrote: > > 15 isn't the length of the string, is that really what's desired? > > linux/next/sound/firewire/bebob/bebop.c > > ----------------------------- > > static bool > check_audiophile_booted(struct fw_unit *unit) > { > char name[24] = {0}; > > if (fw_csr_string(unit->directory, CSR_MODEL, name, sizeof(name)) < 0) > return false; > > return strncmp(name, "FW Audiophile Bootloader", 15) != 0; > }
Indeed it looks bogus. Even "FW...." string is already 24 letters, so it's over name[] array size.
Sakamoto-san, could you fix it properly?
thanks,
Takashi
| |