lkml.org 
[lkml]   [2016]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] mtd: maps: add missing iounmap() in error path
Date
This patch was triggered by the following Coccinelle error:

./drivers/mtd/maps/sc520cdp.c:246:3-9: \
ERROR: missing iounmap; ioremap on line 242 \
and execution via conditional on line 244

Signed-off-by: Luis Henriques <henrix@camandro.org>
---
drivers/mtd/maps/sc520cdp.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/mtd/maps/sc520cdp.c b/drivers/mtd/maps/sc520cdp.c
index 093edd51bdc7..7a27ed345d0d 100644
--- a/drivers/mtd/maps/sc520cdp.c
+++ b/drivers/mtd/maps/sc520cdp.c
@@ -243,6 +243,10 @@ static int __init init_sc520cdp(void)

if (!sc520cdp_map[i].virt) {
printk("Failed to ioremap_nocache\n");
+ if (i) {
+ while (--i)
+ iounmap(sc520cdp_map[i].virt);
+ }
return -EIO;
}

\
 
 \ /
  Last update: 2016-11-16 23:52    [W:0.066 / U:1.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site